Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(remix-server-runtime): reimplement Jsonify type utility #7605

Merged
merged 9 commits into from
Oct 11, 2023
Merged

refactor(remix-server-runtime): reimplement Jsonify type utility #7605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d41249
remove incorrect test case
pcattori Oct 10, 2023
c02c950
reimplement jsonify util
pcattori Oct 7, 2023
b34f8e3
use new jsonify implementation in serializefrom
pcattori Oct 10, 2023
4c64d18
add test for jsonifying classes
pcattori Oct 10, 2023
ed95333
remove no-op test
pcattori Oct 10, 2023
07a1a62
Prioritize `toJSON`
pcattori Oct 10, 2023
e2ea774
add changeset
pcattori Oct 10, 2023
99e93ac
formatting
pcattori Oct 11, 2023
be4cb07
remove unused type-fest dep
pcattori Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/stale-apples-reply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@remix-run/react": patch
"@remix-run/server-runtime": patch
---

Emulate types for `JSON.parse(JSON.stringify(x))` in `SerializeFrom`

Notably, type fields that are only assignable to `undefined` after serialization are now omitted since
`JSON.stringify |> JSON.parse` will omit them. See test cases for examples.

Also fixes type errors when upgrading to v2 from 1.19
331 changes: 0 additions & 331 deletions packages/remix-react/__tests__/hook-types-test.tsx
View file
Open in desktop

This file was deleted.

Loading