Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(vite): upgrade Vanilla Extract Vite plugin #8063

Merged

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Nov 20, 2023

Follow-up to #8000.

As of v3.9.2 of the Vanilla Extract Vite plugin, you no longer need to set emitCssInSsr: true when using the Remix Vite plugin (fixed in vanilla-extract-css/vanilla-extract#1239). This PR upgrades our version of the Vanilla Extract Vite plugin and updates the tests to remove emitCssInSsr: true.

Copy link

changeset-bot bot commented Nov 20, 2023

⚠️ No Changeset found

Latest commit: 133356d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit ddd60a5 into dev Nov 20, 2023
5 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/upgrade-vanilla-extract-vite-plugin branch November 20, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant