-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-dev/vite): remove Vite wrapper functions #8120
fix(remix-dev/vite): remove Vite wrapper functions #8120
Conversation
🦋 Changeset detectedLatest commit: 0709ec4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Definitely better than what we had before IMO.
One thing I'm debating now is whether it makes sense to inline a small utility in server.mjs
just to clean up the ternary / .then(...)
logic. Something like:
// server.mjs
async function createViteServer() {
if (process.env.NODE_ENV === "production") return undefined
let { createServer } = await import("vite")
return createServer({
server: {
middlewareMode: true
}
})
}
let vite = await createViteServer()
if (vite) {
/* ... */
}
// etc.
To be clear, this is not API we would maintain and export, but rather just code we include as part of the examples/templates to make things a bit easier to follow.
Naming tbd. E.g. could be let dev = await createDev()
instead. Not sure what I prefer.
Update: the more I look at this the more I prefer the existing "just inline it all" solution. No need to choose good names for abstractions that don't exist!
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Based on a suggestion by @pcattori, this PR removes the indirection of calling out to Vite via Remix APIs. Instead, we now keep the API surface area as small as possible and get consumers using custom servers to interact with Vite directly.