Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): bundle CSS from client entry #8143

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

markdalgleish
Copy link
Member

Without this fix, CSS from the client entry appears to work in dev (after a flash of unstyled content), but the styles are then missing in the production build.

This PR ensures that:

  • In dev, CSS from the client entry is included in the string of critical CSS to avoid FOUC.
  • In production, any bundled CSS from the client entry is included with the root route.

To test this, CSS imported from the client entry has been added to Vite CSS tests for both dev and build.

Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: 25a7e92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Pedro Cattori <pcattori@gmail.com>
@markdalgleish markdalgleish merged commit c043a66 into dev Nov 28, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/client-entry-css branch November 28, 2023 01:47
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 28, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🤖 Hello there,

We just published version 2.4.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.4.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants