Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-remix): only update "*" versions for Remix dependencies #8458

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

ahuth
Copy link
Contributor

@ahuth ahuth commented Jan 8, 2024

This PR updates create-remix so that it only updates "*" dependencies for @remix-run/* packages.

For example, when create-remix runs, we currently get this change

"dependencies": {
-  "@remix-run/react": "*",
+  "@remix-run/react": "^2.4.1",

Unfortunately, this also affects non-Remix dependencies, such as:

"dependencies": {
-  "@remix-run/react": "*",
+  "@remix-run/react": "^2.4.1",
-  "@myorg/some-random-dep": "*"
+  "@myorg/some-random-dep": "^2.4.1"

which breaks when version 2.4.1 (or whatever the current Remix release is) doesn't exist.

Closes: # n/a

  • Docs
  • Tests

Testing Strategy:

Unit test

Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: 61da73d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 8, 2024

Hi @ahuth,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 8, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@markdalgleish markdalgleish changed the base branch from main to dev January 9, 2024 00:08
@markdalgleish markdalgleish changed the title create-remix: only update "*" versions for @remix-run/* dependencies fix(create-remix): only update "*" versions for Remix dependencies Jan 9, 2024
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@markdalgleish markdalgleish merged commit 579f8e1 into remix-run:dev Jan 9, 2024
9 checks passed
@ahuth ahuth deleted the star-versions branch January 9, 2024 00:35
Copy link
Contributor

github-actions bot commented Jan 9, 2024

🤖 Hello there,

We just published version 2.5.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants