Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isSpaMode to server build virtual module type #8492

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jan 11, 2024

Fixes a type error in the cloudflare pages server (and potentially other spots) where the server build is imoprted from the virtual module:

Screenshot 2024-01-11 at 3 38 21 PM

Screenshot 2024-01-11 at 3 40 11 PM

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 4d5898d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Jan 12, 2024 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit 24a831b into dev Jan 12, 2024
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/server-build-spa-mode-type branch January 12, 2024 18:19
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 12, 2024
lpsinger added a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request Jan 15, 2024
lpsinger added a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request Jan 15, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 18, 2024
lpsinger added a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request Jan 22, 2024
lpsinger added a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev/server-build.ts is missing isSpaMode
1 participant