Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quirks mode warning for SPA template #8495

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Fix quirks mode warning for SPA template #8495

merged 8 commits into from
Jan 16, 2024

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Jan 12, 2024

  1. Set up a new Remix app using the instructions for SPA Mode
  2. Start the dev server with remix vite:dev
  3. Open Firefox Dev Tools and observe the warning:
This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6d09ddb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 12, 2024

Hi @mrm007,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 12, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

Thank you for the PR! Would you mind adding a changeset and pointing this to dev since it touches source code?

@brophdawg11
Copy link
Contributor

Also worth nothing that if this is an issue for anyone before this update gets released, you can npx remix reveal and make this change in your own app/entry.server.tsx

@mrm007 mrm007 changed the base branch from main to dev January 13, 2024 00:55
@brophdawg11 brophdawg11 self-assigned this Jan 16, 2024
@brophdawg11 brophdawg11 merged commit 93b8272 into remix-run:dev Jan 16, 2024
9 checks passed
@brophdawg11
Copy link
Contributor

Thanks @mrm007!

@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@mrm007
Copy link
Contributor Author

mrm007 commented Jan 17, 2024

Thanks for adding tests!

@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.5.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 left review comments

Assignees

@brophdawg11 brophdawg11

Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrm007 @brophdawg11