Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Validate MDX Rollup plugin order #8690

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Feb 6, 2024

With the introduction of #8627, plugin order now matters when using Rollup plugins since only Vite plugins can set enforce: "pre". Most commonly, this is going to cause errors if consumers have added the MDX Rollup plugin after the Remix plugin in their Vite plugins array.

Inspired by vite-plugin-react-swc, this PR adds an explicit error message when the MDX plugin is in the wrong order rather than allowing a lower level error message to surface when Remix tries to work with unprocessed MDX files.

I've written the code in a way that makes it easy to add more plugin order checks in the future. I've also added a test to ensure the validation works as expected.

Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: 52aea1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 98340fa into dev Feb 6, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/vite-mdx-plugin-order branch February 6, 2024 03:25
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Feb 6, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant