Vite: Validate MDX Rollup plugin order #8690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of #8627, plugin order now matters when using Rollup plugins since only Vite plugins can set
enforce: "pre"
. Most commonly, this is going to cause errors if consumers have added the MDX Rollup plugin after the Remix plugin in their Vite plugins array.Inspired by vite-plugin-react-swc, this PR adds an explicit error message when the MDX plugin is in the wrong order rather than allowing a lower level error message to surface when Remix tries to work with unprocessed MDX files.
I've written the code in a way that makes it easy to add more plugin order checks in the future. I've also added a test to ensure the validation works as expected.