-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug with SPA mode when the root route had no children #8747
Conversation
🦋 Changeset detectedLatest commit: 1e20ee4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
// We don't want to pick up the app/routes/_index.tsx file from | ||
// the template and instead want to use only the src/root.tsx | ||
// file below | ||
appDirectory: "src", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, that's a neat trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol - it took me far too long to figure out why my test wasn't failing and I finally dug deep enough to find out that we copy a template first, so even though I wasn't defining an index route, my test ended up with one. And I started down the road of a flag to delete files/not copy the template before I realized I could do this instead
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
No description provided.