Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inline sourcemaps for server build #901

Closed
wants to merge 1 commit into from
Closed

Use inline sourcemaps for server build #901

wants to merge 1 commit into from

Conversation

zigomir
Copy link

@zigomir zigomir commented Dec 5, 2021

Fixes #367

@jacob-ebey
Copy link
Member

I'd actually like to make this configurable. The issue comes when deploying places like CF that have a limit on script sizes. inline source maps will almost double the files size a lot of the time.

@zigomir
Copy link
Author

zigomir commented Dec 6, 2021

When you run build command, sourcemap is set to false so this shouldn't affect prod build script size.

@ryanflorence
Copy link
Member

Thanks, we actually started on this before seeing your PR 🥲 #1087

@zigomir zigomir deleted the dev branch December 17, 2021 05:44
@zigomir
Copy link
Author

zigomir commented Dec 17, 2021

No problem :) Happy to see it landed and debugging will be nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zigomir @jacob-ebey @ryanflorence