Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow . in create-remix --template repo name #9026

Conversation

TooTallNate
Copy link
Contributor

@TooTallNate TooTallNate commented Mar 10, 2024

Period is a valid character in GitHub repository names.

Testing Strategy

Build this branch and then run:

node packages/create-remix/dist/cli.js --template TooTallNate/nx.js-remix

It should work, instead of the current behavior of printing an error.

Period is a valid character in GitHub repository names.
Copy link

changeset-bot bot commented Mar 10, 2024

🦋 Changeset detected

Latest commit: 4b27d0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 10, 2024

Hi @TooTallNate,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 10, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@markdalgleish markdalgleish changed the title [create-remix] Allow . in repo name when using --template flag Allow . in create-remix --template flag Mar 26, 2024
@markdalgleish markdalgleish changed the title Allow . in create-remix --template flag Allow . in create-remix --template repo name Mar 26, 2024
@markdalgleish
Copy link
Member

Thanks for the PR!

@markdalgleish markdalgleish merged commit 1fa128c into remix-run:dev Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants