chore(remix-node): put native fetch behind config option #9198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(remix-serve): default to native fetch for single-fetch
🦋 Changeset detectedLatest commit: 7cb7f93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jacob-ebey
commented
Apr 4, 2024
| @@ -37,6 +38,7 @@ module.exports = function rollup() { | |||
| extensions: [".ts", ".tsx"], | |||
| }), | |||
| nodeResolve({ extensions: [".ts", ".tsx"] }), | |||
| commonjs({ ignoreDynamicRequires: true }), | |||
There was a problem hiding this comment.
Don't hoist dynamic require's to to the module scope to avoid loading two polyfills at startup.
jacob-ebey
commented
Apr 4, 2024
| @@ -4,5 +4,5 @@ module.exports = { | |||
| displayName: "testing", | |||
| setupFiles: [], | |||
| testEnvironment: "jsdom", | |||
| setupFilesAfterEnv: ["@testing-library/jest-dom", "./jest.setup.js"], | |||
| setupFilesAfterEnv: ["./jest.setup.js", "@testing-library/jest-dom"], | |||
There was a problem hiding this comment.
The order here matters due to testing-library setting up globals badly if they don't exist.
brophdawg11
reviewed
Apr 4, 2024
brophdawg11
approved these changes
Apr 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(remix-serve): default to native fetch for single-fetch
Since there are some quite major differences between our, and native fetch implementations we have opted to keep our polyfill around for existing apps until the next major to avoid introducing unexpected issues for users specifically around the garbage collection behavior of response bodies.
Due to reliance on a more spec compliant headers implementation for single fetch, single fetch opts you into native fetch.