Fix typings for response in LoaderFunctonArgs/ActionFunctionArgs #9254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brophdawg11
commented
Apr 18, 2024
•
brophdawg11
commented
🦋 Changeset detectedLatest commit: 8e8ecaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Apr 18, 2024
| @@ -40,6 +40,9 @@ export type ResponseStubOperation = [ | |||
| export type ResponseStub = { | |||
| status: number | undefined; | |||
| headers: Headers; | |||
| }; | |||
|
|
|||
| export type ResponseStubImpl = ResponseStub & { | |||
There was a problem hiding this comment.
This is what we use internally now - since it contains the symbol. We cast to ResponseStub when handing off to loaders/actions
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.