Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Update deno template path #9357

Merged
merged 1 commit into from
May 2, 2024

Conversation

haines
Copy link
Contributor

@haines haines commented May 2, 2024

The nightly build is currently failing with

[Error: ENOENT: no such file or directory, open '/home/runner/work/remix/remix/templates/deno/.vscode/resolve_npm_imports.json']

because the deno template was moved in #9077.

This PR updates the path in the incrementRemixVersion utility to solve that.

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
Copy link

changeset-bot bot commented May 2, 2024

⚠️ No Changeset found

Latest commit: bdae16f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11 brophdawg11 merged commit bc70ade into remix-run:dev May 2, 2024
2 checks passed
@haines haines deleted the fix-nightly-build branch May 2, 2024 12:35
@haines
Copy link
Contributor Author

haines commented May 2, 2024

No problem! Would you mind manually re-running the nightly build job? I am keen to try out #9349 and it would save me patching the package if I can use the nightly build.

@brophdawg11
Copy link
Contributor

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants