Remove AbortController and respect URL length limits #9626
Conversation
🦋 Changeset detectedLatest commit: f298e0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -193,10 +187,7 @@ export function useFogOFWarDiscovery( | |||
| attributeFilter: ["data-discover", "href"], | |||
| }); | |||
|
|
|||
| return () => { | |||
| fogOfWar?.controller?.abort(); | |||
There was a problem hiding this comment.
This is technically against the "rules of react" because we're not cleaning up our side effect, but functionally it shouldn't cause any issues since the requests are additive and shouldn't have race conditions
brophdawg11
changed the title
brophdawg11
changed the title
| knownGoodPaths.add(path); | ||
| nextPaths.delete(path); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This could produce false positives, so we only add to knownGoodPaths in response to a manifest fetch where we matched on the server
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
StrictMode, and there's no real benefit to aborting since the response is still valid so might as well patch those routes to avoid subsequent requests if we navigate back to those routes.POSTrequest if the URL goes beyond 4196 characters (a fairly conservative limit) to avoid running into URL or Request size limitsCache-Controlresponse header