Dev env and Github actions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmh
commented
Dec 18, 2024
We're using nix, direnv and devenv to run the project's tests in both dev and CI environments.
|
Qa steps worked for me! |
sgoel
approved these changes
Dec 18, 2024
|
@davidmh you mentioned in standup that this diff allows developers to not have to worry about the java dependencies on their system, but where is that defined? I don't see a JDK version being referenced anywhere |
|
Is set here: Lines 4 to 5 in 166d3f9 Since we're not specifying a jdk version, it goes with the default for the current release of devenv: https://github.com/cachix/devenv/blob/main/src/modules/languages/java.nix#L17-L26 It installs java 21.0.2: 
Do we need a specific version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're planning on modifying more than a few small things in this fork, we should:
QA steps
Since you already have nix and direnv installed, all you need to install now is devenv as a standalone tool:
After that all you need to do is run
direnv allowin the path for this project.