Issue #2074 AutoComplete with jline3 is showing hidden values

remkop · Jul 30, 2023 · 460496b · 460496b
1 parent f132312
commit 460496b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/picocli-shell-jline3/src/main/java/picocli/shell/jline3/PicocliCommands.java b/picocli-shell-jline3/src/main/java/picocli/shell/jline3/PicocliCommands.java
@@ -177,6 +177,7 @@ public void complete(LineReader reader, ParsedLine commandLine, List<Candidate>
                 String buffer = word.substring(0, commandLine.wordCursor());
                 int eq = buffer.indexOf('=');
                 for (OptionSpec option : sub.getCommandSpec().options()) {
+                    if (option.hidden()) continue;
                     if (option.arity().max() == 0 && eq < 0) {
                         addCandidates(candidates, Arrays.asList(option.names()));
                     } else {
@@ -193,7 +194,9 @@ public void complete(LineReader reader, ParsedLine commandLine, List<Candidate>
             } else {
                 addCandidates(candidates, sub.getSubcommands().keySet());
                 for (CommandLine s : sub.getSubcommands().values()) {
-                    addCandidates(candidates, Arrays.asList(s.getCommandSpec().aliases()));
+                    if (!s.getCommandSpec().usageMessage().hidden()) {
+                        addCandidates(candidates, Arrays.asList(s.getCommandSpec().aliases()));
+                    }
                 }
             }
         }