[#648][#1846] fix broken tests

remkop · Oct 30, 2022 · 6016ab7 · 6016ab7
1 parent 5098341
commit 6016ab7
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/test/java/picocli/TypeConversionTest.java b/src/test/java/picocli/TypeConversionTest.java
@@ -488,8 +488,8 @@ public void testCharConverterInvalidError() throws ParseException {
  public void testCharArrayConverter() {
  try {
  final SupportedTypes cli = new SupportedTypes();
- CommandLine.populateCommand(new SupportedTypes(), "-charArray", "abcd");
- assertEquals(new char[]{'a', 'b', 'c', 'd'}, cli.charArrayField);
+ CommandLine.populateCommand(cli, "-charArray", "abcd");
+ assertArrayEquals(new char[]{'a', 'b', 'c', 'd'}, cli.charArrayField);
  } catch (Exception exception) {
  fail("Unexpected exception while converting char[] type: " + exception.getMessage());
  }
@@ -727,8 +727,7 @@ public int handleParseException(ParameterException ex, String[] args) {
  //System.out.println(sw);
  assertTrue(sw.toString().startsWith("picocli.CommandLine$ParameterException: Invalid value for positional parameter at index 0 (<sqlTypeParam>): cannot convert 'anything' to int (java.lang.IllegalStateException: bad converter)"));
  assertTrue(sw.toString().contains(String.format("Caused by: java.lang.IllegalStateException: bad converter%n" +
- "\tat picocli.TypeConversionTest$ErrorConverter.convert(TypeConversionTest.java:674)%n" +
- "\tat picocli.TypeConversionTest$ErrorConverter.convert(TypeConversionTest.java:672)")));
+ "\tat picocli.TypeConversionTest$ErrorConverter.convert(TypeConversionTest.java:")));
  }
  static class TypeConversionExceptionConverter implements ITypeConverter<Integer> {
  public Integer convert(String value) throws Exception {
@@ -763,8 +762,7 @@ public int handleParseException(ParameterException ex, String[] args) {
  //System.out.println(sw);
  assertTrue(sw.toString().startsWith("picocli.CommandLine$ParameterException: Invalid value for positional parameter at index 0 (<sqlTypeParam>): I am always thrown"));
  assertTrue(sw.toString(), sw.toString().contains(String.format("Caused by: picocli.CommandLine$TypeConversionException: I am always thrown%n" +
- "\tat picocli.TypeConversionTest$TypeConversionExceptionConverter.convert(TypeConversionTest.java:724)%n" +
- "\tat picocli.TypeConversionTest$TypeConversionExceptionConverter.convert(TypeConversionTest.java:722)%n")));
+ "\tat picocli.TypeConversionTest$TypeConversionExceptionConverter.convert(TypeConversionTest.java:")));
  }
  static class CustomConverter implements ITypeConverter<Integer> {
  public Integer convert(String value) { return Integer.parseInt(value); }