-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking changes in JLine 3.15.0 #1098
Comments
Thank you for raising this! We will make It looks like one of the JLine authors, @mattirn, has already submitted a pull request to change the dependency and the corresponding I would like to also update the documentation to show examples for the |
Thanks for the quick turnaround, @mattirn! Regarding the documentation, instead of keeping multiple versions of The README.md file could then contain the notes with links to the files locked to their relevant commits (e.g. JLine 3.13.2 and Picocli 4.1.2). Having multiple versions of the file in the README seems hard to maintain, and all the example changes have to be duplicated to the README. I can make a PR for this once #1099 goes in, if you'd like. |
@thetoothpick I merged #1099 into master. I would like for the documentation to show actual code, at least for the latest version, rather than a link. Also, the code may be a bit long, we can look into making it shorter. Or perhaps have a short initial example and a longer full example. Thoughts? |
Yea, I think that makes sense to split out the older versions and keep the latest in the README. |
Hi @thetoothpick, have you had a chance to take a look at this? |
@remkop I created a wiki page for the old examples. Looking at the latest PR, the example didn't actually change for the latest version, so I left the minimum versions as they were. The example for JLine 3.13.2 and Picocli 4.1.2 is now on this wiki page. I also opened a PR (#1117). I'll add some comments about cleaning up the example there. |
Hello,
JLine has released version 3.15.0, and it includes some breaking changes (some classes in
org.jline.builtins
were moved toorg.jline.console
), sopicocli-shell-jline3
4.3.2 doesn't compile against it.The text was updated successfully, but these errors were encountered: