Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ansi.Text.clone() with copy constructor #586

Closed
remkop opened this issue Jan 2, 2019 · 0 comments
Closed

Replace Ansi.Text.clone() with copy constructor #586

remkop opened this issue Jan 2, 2019 · 0 comments

Comments

@remkop
Copy link
Owner

remkop commented Jan 2, 2019

Current Ansi.Text.clone() implementation may result in bugs since the underlying styled list and plaintext buffer are shared between the original and the copy. It is safer to make a full copy.

The clone() implementation can delegate to the copy constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant