-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jline3Version in order to avoid stackoverflow error #1313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
=========================================
Coverage 93.78% 93.78%
Complexity 469 469
=========================================
Files 2 2
Lines 6951 6951
Branches 1864 1864
=========================================
Hits 6519 6519
Misses 146 146
Partials 286 286 Continue to review full report at Codecov.
|
@rupert-madden-abbott thank you for the pull request! |
@remkop Thanks very much. I've had a look at the README and, personally, I don't think maintaining a version compatibility range in a README is a good idea unless you have tests (automated or otherwise) which are specifically testing picocli-shell-jline3 versions against different jline versions. I'm not sure when this stackoverflow issue was introduced. It may have only been in jline 3.17.1. In that case, the latest version of picocli-shell-jline3 may be compatible with both 3.17.0 (and less) and 3.18.0 (and more). But I haven't tested those versions so I can't say for sure. All I know is that version 3.17.1 should not be used. If you are happy that the version compatibility table is otherwise correct, perhaps we could just add a note saying to not use jline 3.17.1 with a link to this PR or to the jline issue? |
I like your suggestion. |
@remkop awesome, I've pushed an update. See you what you think. |
Merged. Thank you for the contribution! |
This reverts commit fff4c8f.
This reverts commit fff4c8f.
Using picocli-shell-jline3:4.6.1, and copying the example containing this README exactly leads to a stack overflow error. Somebody else reported this issue to jline where they have recommended bumping the jline version to 3.18.0.
I've tested locally, encountered the stack overflow, then bumped the version and confirmed the stack overflow is fixed.