Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of deprecated Maven properties #1314

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

charphi
Copy link
Contributor

@charphi charphi commented Jan 25, 2021

Fix the following warnings in Maven when using configuration specified in codegen documentation:

The expression ${groupId} is deprecated. Please use ${project.groupId} instead.
The expression ${artifactId} is deprecated. Please use ${project.artifactId} instead.
It is highly recommended to fix these problems because they threaten the stability of your build.
For this reason, future Maven versions might no longer support building such malformed projects.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #1314 (f8e14c7) into master (84013e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1314   +/-   ##
=========================================
  Coverage     93.78%   93.78%           
  Complexity      469      469           
=========================================
  Files             2        2           
  Lines          6951     6951           
  Branches       1864     1864           
=========================================
  Hits           6519     6519           
  Misses          146      146           
  Partials        286      286           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84013e3...f8e14c7. Read the comment docs.

@remkop remkop added this to the 4.7 milestone Jan 26, 2021
@remkop remkop merged commit c28db27 into remkop:master Jan 26, 2021
@remkop
Copy link
Owner

remkop commented Jan 26, 2021

Merged. Thank you for the contribution!
I will update the release notes when I get to my PC.

remkop added a commit that referenced this pull request Jan 31, 2021
@remkop
Copy link
Owner

remkop commented Jan 31, 2021

Release notes updated.

@remkop remkop modified the milestones: 4.7, 4.6.2 Feb 23, 2021
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants