Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified detection of getter & setter in TypedMember constructor #1518

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Simplified detection of getter & setter in TypedMember constructor #1518

merged 1 commit into from
Jan 11, 2022

Conversation

rgoldberg
Copy link
Contributor

Simplified detection of getter & setter in TypedMember constructor

@remkop
Copy link
Owner

remkop commented Dec 16, 2021

Hi @rgoldberg, just FYI: I am on the Apache Logging PMC and as you can imagine a bit preoccupied with the Log4j issue.
I will get back to this but just wanted to let you know that it may take a while. Thanks!

@rgoldberg
Copy link
Contributor Author

Yeah, you must be very busy. No urgency. Good luck with it.

I'm just cleaning up code that seemed awkward when I first read it. I think the modifications should make it easier to understand, and incidentally improve performance (probably negligibly, but the straightforward code is my main aim, not massive performance gains).

@remkop remkop added this to the 4.6.3 milestone Jan 11, 2022
@remkop remkop merged commit 62d708a into remkop:master Jan 11, 2022
@remkop
Copy link
Owner

remkop commented Jan 11, 2022

I finally had some time to look at this.
Thank you for the contribution!

remkop added a commit that referenced this pull request Jan 11, 2022
@rgoldberg rgoldberg deleted the typed-member-getter-setter branch January 11, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants