-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[https://github.com/remkop/picocli/issues/1706] Resolve messages against parent resource bundles with updated i18n unit tests #1710
Conversation
Thank you for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally could make time to look at this. Sorry for the delay.
Overall, this looks great, thank you very much!
I have some minor feedback about the coding style (whitespace), can you take a look at that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found more whitespace style issues. Sorry to be nitpicking, but I would prefer to keep the code style consistent. 😓
Can you take a look?
… i18n unit tests and fixed whitespace.
Merged. Thank you for the contribution! I will update the release notes when I get to my PC. |
[https://github.com//issues/1706] Resolve messages against parent resource bundles. Also provided are updated i18n unit tests.