#2102 PropertiesDefaultProvider at first try to load properties from … #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from classpath
remkop
requested changes
Sep 18, 2023
There was a problem hiding this comment.
This looks good overall, many thanks!
Will you be able to add a unit test please?
One minor point is that the user object of the CommandSpec may be null in some circumstances (for applications that use the programmatic API to create a CommandSpec, instead of reflection from annotated application classes).
So the logic needs a minor change to accommodate this.
remkop
reviewed
Sep 18, 2023
added 2 commits
September 18, 2023 12:28
… from classpath - check if commandSpec.userObject is null
… from classpath - addded test for read default values from resource classpath
something tried if not enough not sure if I get quickly deeper insights in tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…classpath