Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC-002: Progress on the front-end #5

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

angeloreale
Copy link
Member

@angeloreale angeloreale commented Feb 7, 2024

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

EC-002

After good progress on the tenancy aspect last night, decided to switch to some progress on the user interface side of things, to steam off a little.

This PR updates the default logos, and starts implementing the skeleton of a design system.

Previously, we've added MUI/base, so we'd have more freedom on specifying our design choices (the way things look), our CSS solution (pre/post-process, CSS-in-JS, Tailwind, etc) as well as not having to re-invent the wheel for every UI interaction.

We're currently using css modules and will create our own syntax solution for it as a jsx pragma, called nsx, where we'll abstract the way cslx works for more ergonomics while using css modules, all while keeping it the lightest.

#2

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

next.config.js Outdated Show resolved Hide resolved
public/logo.svg Outdated Show resolved Hide resolved
src/app/components/client/navbar-view.tsx Outdated Show resolved Hide resolved
src/app/components/client/usersettings-view.tsx Outdated Show resolved Hide resolved
src/app/page.tsx Outdated Show resolved Hide resolved
Copy link
Member Author

@angeloreale angeloreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angeloreale angeloreale merged commit c688d1f into dev Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant