Replace node polyfills with maintained version #32
Conversation
…th `rollup-plugin-polyfill-node`
| const path = args.path.replace(prefixFilter, '') | ||
| const isCommonjs = | ||
| args.namespace !== commonjsNamespace && | ||
| args.kind === 'require-call' |
There was a problem hiding this comment.
I copied this from the other resolver but didn't really take the time to understand fully what it is doing so may need some consideration.
|
If you want to use this for Remix i think it's better that you create a plugin package in the Remix monorepo so you can quickly fix bugs and add features, i don't want to maintain a core piece of the Remix echosystem Replacing the polyfill could cause a lot of issues and inconsistencies to other projects already using this plugin Feel free to copy the plugin source code in the Remix repo |
Totally agree. I'm not affiliated with Remix just have an outstanding issue there related to this. I'll leave the patch up if you want to explore it to move away from the deprecated lib or if anyone else wants to take it. Thanks |
|
There is a PR on Remix to update this plugin: I hope that fixes the issue. Best regard |
Possible solution to discussion on #29 @MichaelDeBoey