Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@remotion/player: Don't overwrite global TypeScript Types #4056

Merged
merged 1 commit into from
Jul 9, 2024
Merged

@remotion/player: Don't overwrite global TypeScript Types #4056

merged 1 commit into from
Jul 9, 2024

Conversation

JonnyBurger
Copy link
Member

@JonnyBurger JonnyBurger commented Jul 8, 2024 •
edited
Loading

Somewhat related question: it appears that PlayerControls.d.ts from @remotion/player is mutating the global namespace to add full screen support to HTMLDivElement, but that causes other libraries like Material UI to report TypeScript errors, since they don’t have the same implementation.

@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 4:23pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 4:23pm

@JonnyBurger JonnyBurger merged commit 1bbd532 into main Jul 9, 2024
13 checks passed
@JonnyBurger JonnyBurger deleted the dont-overwrite-fullscreen-types branch July 9, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonnyBurger