-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat. better handling of media keys in browser #4386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JonnyBurger
previously approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
@JonnyBurger looks like a test is wasting infinite amount of resources.. |
auto-merge was automatically disabled
October 10, 2024 20:32
Head branch was pushed to by a user without write access
JonnyBurger
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4381
/claim #4381
Screencast from 2024-10-09 20-56-12.webm
Screencast from 2024-10-09 20-55-26.webm
this PR Implements the following:
usePlayback
hook now expects a new optional argument namedbrowserMediaControlsEnabled
which specifies whether to allow interaction through browser's media controlsplayPause
component ofstudio
is changed so that it invokes the player hook with browser media controls enabled, which results in the player only allowing controls if inside studio.@JonnyBurger please feel free to suggest any required changes.
Note: Looks like the SSR integration is failing from a previous change, I checked it by checking out to to a previous commit.