Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. better handling of media keys in browser #4386

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

hunxjunedo
Copy link
Contributor

@hunxjunedo hunxjunedo commented Oct 9, 2024

fixes #4381
/claim #4381

Screencast from 2024-10-09 20-56-12.webm
Screencast from 2024-10-09 20-55-26.webm

this PR Implements the following:

  • improves the behavior of browser's native media controls
  • allows the media controls to control both composition and audio
  • when the player is first loaded, the media controls can't be used until the media is played by some other means
  • the usePlayback hook now expects a new optional argument named browserMediaControlsEnabled which specifies whether to allow interaction through browser's media controls
  • the playPause component of studio is changed so that it invokes the player hook with browser media controls enabled, which results in the player only allowing controls if inside studio.
  • cleanup for the action-handlers is also implemented successfully.

@JonnyBurger please feel free to suggest any required changes.
Note: Looks like the SSR integration is failing from a previous change, I checked it by checking out to to a previous commit.

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:53pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:53pm
remotion-convert ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:53pm

@vercel vercel bot temporarily deployed to Preview – remotion-convert October 10, 2024 13:39 Inactive
JonnyBurger
JonnyBurger previously approved these changes Oct 10, 2024
Copy link
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@hunxjunedo
Copy link
Contributor Author

hunxjunedo commented Oct 10, 2024

@JonnyBurger looks like a test is wasting infinite amount of resources..

@JonnyBurger JonnyBurger merged commit 62279fe into remotion-dev:main Oct 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling of Media keys
2 participants