Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few negative examples #28

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Add a few negative examples #28

merged 5 commits into from
Jul 5, 2024

Conversation

septract
Copy link
Collaborator

Creates a subdirectory negative-examples containing examples should always fail.

(In the other subdirectories of example-archive, proofs that fail represent true properties that cannot be established by CN for whatever reason).

@septract septract linked an issue Jun 14, 2024 that may be closed by this pull request
6 tasks
@septract septract marked this pull request as ready for review July 4, 2024 22:08
@septract septract requested a review from dc-mak July 4, 2024 22:11
Copy link
Collaborator

@dc-mak dc-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, though maybe naming it "should-fail" or "expected-fail" would be clearer? We need to think about the types of error we have and how to name and signal them...

@septract septract merged commit 1b57e33 into main Jul 5, 2024
@septract septract deleted the mdd/negative-examples branch July 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write some negative tests
2 participants