Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to copy multiple selected source translations to target #27

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mstarke
Copy link

@mstarke mstarke commented Nov 17, 2017

This enables multi-selection for rows and also extends the copy source to target action to use the complete selection not just the last selected row.

@remuslazar
Copy link
Owner

@mstarke thank you for the PR, sounds good! I will review the changes. Currently being busy with other things, this could take a while.

A new release is also planned (medium-term), including the upgrade for Swift4 and Xcode 9.x and also other stuff, e.g. native dynamic row height for High Sierra Users etc.

@mstarke
Copy link
Author

mstarke commented Nov 20, 2017

Awesome. Please be kind with the review since I have no actual clue about Swift but rather dwell happily in the obj-c past ;-)

@remuslazar
Copy link
Owner

@mstarke could you please rebase your PR to the current develop branch? The codebase being now Swift 4.2 compliant, there are some minor tweaks needed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants