-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moderate advisory in dependency #2023
Comments
Here's the problem: yeoman/update-notifier#218 update-notifier needs to update its dependency on latest-version in order to fix this, but it seems somewhat unlikely to happen given the lack of development (last commit over a year ago) and lack of response to similar issues (yeoman/update-notifier#216, yeoman/update-notifier#214) Seems like the real solution here is to replace update-notifier: #1961 |
This should've been fixed by v6.0.0 of |
I created a pull request for this, it should fix it. |
releasing now. |
Just wanted to mention a directly related issue I opened regarding the vulnerability in the Thanks @gaborszita and @remy ! |
Had to revert as it borked installs. The next release, I hope, will remove update-notifier as it keeps bringing in issues. |
@remy is there an open related issue/pr we can track? |
In the server, nodemon v5.0.16 was depending on update-notifier v5.1, which has got v9.6 - which has a vulnerability - in its dependency chain. This was reportedly corrected in update-notifier v6, released very recently, but this still isn't included in nodemon v5.0.18 so manually changed dependency to update-notifier v6, which has removed the vulnerability and associated warning. See remy/nodemon#2023 for more info. In the client, react-scripts had a vulnerability in dependency nth-check v1.0.2. Apparently it's sufficient to move react-scripts to devDependencies (facebook/create-react-app#11174) but I'm not sure if this will appease Dependabot. If not, I'll likely try manually updating the nth-check version in the dependency chain to see if that fixes the issue without breaking anything.
I am on
nodemon
v2.0.16
andyarn audit
tells me that there's a vuln in one of the dependencies:GHSA-pfrx-2q88-qq97
I have no clue if
update-notifiier
and the rest of the tree-on-down have updated to fix this...but when they do it'd be great if you could update this!Thanks for the great library!
The text was updated successfully, but these errors were encountered: