[v0.8.0] - housekeeping #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though I highly recommend using a portal solution for dialogs and the fact that portal-vue is the de facto solution for vue2 portals, it's not a mandatory aspect of this component, since it can be used with any portal solution.
we no longer provide a styled dialog component
for now, we will upgrade to vue2.7 which shouldn't change anything as we're not using any composition api features.
missed on css depdencies
latest minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
portal-vuedependency: we recommend it's usage, but not a requirement. Also addedvue-simple-portalto playground and it works a-ok with it, so it's our main suggestion now (in readme). closes Remove portal-vue dependency #11. closes Add note about limitation with provide/inject while using portal #16 as well since provide/inject is aportal-vuecaveat and not our responsibility to warn users since it's not a dependency and there's a warning it the its docs.focus-trapto the latest version