Feat/mixin and or exported fns #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a particular situation where directives are not the best alternative: Renderless components that exposes their internal functionality via slot scope bindings. Consumers of this componentes usually don't need to be aware of what is binded, just need to do v-bind="slotScope" to their slot component and get on with their lives. The problem is that we can't pass a directive up via scope. A common counterpoint is "just import it on the consumer and apply to the slot-scope element". This is mostly true, but it's also equivalent to say to to mcdonals customer "here's your big mac! Don't forget to add your burger in the middle before eating, since it's served on the side". — weird right? - So this commit export of the "public" directive methods (bind, unbind) that would allow use to programatically use v-click-outside package. A companion namespaced mixin can shortcut the directive bindingValue object format, but I understand that mixins are not that popular and vue3 will make them obsolete, so it's totally optional to remove it from this commit. - updates "examples" with 2 boxes using this version.
|
Same can be achieved without much of a hassle by destructuring the directive property from default export. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.