Simplify installation instructions #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
reviewed
Feb 28, 2017
| ``` | ||
| Then you need to update your `package.json` file to include the `webpacker-react` NPM module: | ||
|
|
||
| `./bin/yarn add webpacker-react@0.1.x` |
There was a problem hiding this comment.
./bin/yarn add webpacker-react adds "webpacker-react": "^0.1.0", to the package.json, which is better here.
|
Good catch, thanks! It does not fixes #11 completely as we still need to update the test & example apps for the new Webpacker, but at least the doc will be correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
package.json(and related files) to the project root fromvendor/package.jsondirectly. I added ayarncommand to take care of adding thewebpacker-reactmodule & install it.Fixes #11