Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for meshes without index buffers #858

Open
Tracked by #785
jespertheend opened this issue Jan 8, 2024 · 0 comments
Open
Tracked by #785

Support for meshes without index buffers #858

jespertheend opened this issue Jan 8, 2024 · 0 comments
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: WebGPU Renderer Related to the WebGpuRenderer
Milestone

Comments

@jespertheend
Copy link
Collaborator

Right now the Mesh constructor always creates an empty index buffer, and there is no way to to create a mesh without an index buffer.
I think it should be null by default, and only when setting index data should it be created.
Similarly, setIndexData should probably take null as a value, causing the index buffer to be removed.

Also the WebGPU renderer doesn't really handle this case well.

@jespertheend jespertheend added the effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. label Jan 8, 2024
@jespertheend jespertheend added this to the MVP milestone Jan 8, 2024
@jespertheend jespertheend added the topic: WebGPU Renderer Related to the WebGpuRenderer label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: WebGPU Renderer Related to the WebGpuRenderer
Projects
None yet
Development

No branches or pull requests

1 participant