Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vec4.w should not be 1 by default #922

Open
jespertheend opened this issue Apr 7, 2024 · 0 comments
Open

vec4.w should not be 1 by default #922

jespertheend opened this issue Apr 7, 2024 · 0 comments
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase
Milestone
MVP

Comments

@jespertheend
Copy link
Collaborator

I'm not sure what is more common, Vec4's with their w set to 0 or to 1. But either way, when you're expecting 0 as the default, you'll likely forget to double check, and when you expect 1 to be the default, you'll likely still double check just in case.

So unless 1 really is way more common, I think a default of 0 probably makes a lot more sense.
@jespertheend jespertheend added the effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase label Apr 7, 2024
@jespertheend jespertheend added this to the MVP milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@jespertheend