Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to catch thrown errors from singleinstancepromise #936

Closed
jespertheend opened this issue May 17, 2024 · 1 comment · Fixed by #940
Closed

Unable to catch thrown errors from singleinstancepromise #936

jespertheend opened this issue May 17, 2024 · 1 comment · Fixed by #940
Assignees
@jespertheend
Labels
Bug It's a bug. effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase
Milestone
MVP

Comments

@jespertheend
Copy link
Collaborator

Specifically it seems like myPromise in run() only handles resolving, not rejecting.
@jespertheend jespertheend added effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase Bug It's a bug. labels May 17, 2024
@jespertheend jespertheend added this to the MVP milestone May 17, 2024
@jespertheend
Copy link
Collaborator Author

There are currently some ignored tests because of this

@jespertheend jespertheend self-assigned this Jun 11, 2024
@jespertheend jespertheend mentioned this issue Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jespertheend jespertheend

Labels
Bug It's a bug. effort: Casual Simple changes that shouldn't take too much time when you're already familiar with the codebase
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

fix(SingleInstancePromise): Make run() reject when the function rejects jespertheend/Renda
1 participant
@jespertheend