Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set licenseConfigurationArn on a LaunchTemplate for macOS #100

Merged
merged 1 commit into from
Jan 5, 2023
Merged

set licenseConfigurationArn on a LaunchTemplate for macOS #100

merged 1 commit into from
Jan 5, 2023

Conversation

cchristous
Copy link
Contributor

@cchristous cchristous commented Jan 4, 2023 •
edited
Loading

This sets the licenseConfigurationArn field on the LaunchTemplate for macOS pools.

Prior to this change I was seeing the ASG fail to create with

AwsSemaphoreAgentStack/autoScalingGroup (autoScalingGroup) You must use a valid fully-formed launch template. One or more licenses need to be specified for a valid Server Manageability call.

Why the license config needs to be referenced by both the launch template and the host resource group is a mystery to me, but this works.

@cchristous cchristous marked this pull request as ready for review January 4, 2023 20:27
@lucaspin lucaspin self-requested a review January 5, 2023 16:05
@lucaspin
Copy link
Collaborator

lucaspin commented Jan 5, 2023

/sem-approve

@lucaspin lucaspin merged commit 594dcb6 into renderedtext:master Jan 5, 2023
@cchristous cchristous deleted the add-license-to-lt branch January 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspin lucaspin Awaiting requested review from lucaspin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchristous @lucaspin