Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure macOS shutdown hook #105

Merged
merged 1 commit into from
Jan 8, 2023
Merged

fix: configure macOS shutdown hook #105

merged 1 commit into from
Jan 8, 2023

Conversation

lucaspin
Copy link
Collaborator

@lucaspin lucaspin commented Jan 8, 2023

Adds a shutdown hook to terminate the instance when the agent shuts down.

The shutdown hook is executed in a non-login shell. Since LaunchD has no default environment generator mechanism like systemD, we'd need to use the launchctl setenv or launchctl config commands for configuring it.

Since the only environment setup needed in that script is to include /usr/local/bin to the PATH, we do it in the script itself, for simplicity.

@lucaspin lucaspin merged commit ff83f7f into master Jan 8, 2023
@lucaspin lucaspin deleted the fix-macos-rotation branch January 8, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant