allow overriding SEMAPHORE_AGENT_STACK_CONFIG values with env vars #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the stack configuration can be provided either as a JSON file via SEMAPHORE_AGENT_STACK_CONFIG or as environment variables, but you can't combine the two. This changes it so that a user can provide a JSON file and then also provide environment variables. If there are duplicates, the environment variables take precedence.
For my use case, I'd like to supply most of my parameters via the JSON file, but I'd also like to pass the
SEMAPHORE_AGENT_AMI
environment variable, so I don't have to store my AMI ID in source code.Testing
I set the
SEMAPHORE_AGENT_AMI
andSEMAPHORE_AGENT_STACK_CONFIG
environment variables then ran a CDK diff and saw: