Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use informer for agent types #4

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat: use informer for agent types #4

merged 2 commits into from
Jan 17, 2024

Conversation

lucaspin
Copy link
Collaborator

Issue

The current way we are discovering agent types through secrets is not optimal:

  • It takes 5min to discover changes in secrets.
  • It makes a lot of of unnecessary API requests to the Kubernetes API server.
  • We are including a cache library (ristretto) when we could use the utilities provided by client-go.

Solution

Use a client-go informer instead.

@lucaspin lucaspin merged commit 02dee75 into main Jan 17, 2024
@lucaspin lucaspin deleted the use-informer-for-secrets branch January 17, 2024 21:53
@lucaspin lucaspin mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lucaspin