Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: agent type name update not evicting old agent type from registry #9

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

lucaspin
Copy link
Collaborator

Issue

If the agent type name changed in the secret, we keep the old agent type in our agent type registry. Only the new agent type name should be kept in the registry.

Solution

When receiving an onUpdate() from the secrets informer, we check if the agent type name changed. If it did, we also deleted the old agent type from the registry.

@lucaspin lucaspin merged commit f018a49 into main Jan 23, 2024
1 check passed
@lucaspin lucaspin deleted the fix-agent-type-name-update branch January 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants