Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setOptions function, revised update function to allow for new options #142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mezmi
Copy link

@mezmi mezmi commented May 28, 2015

Added a setOptions function and revised the update function to allow for new options to be passed to the chart.
Example.

 $('#modalChart').data('easyPieChart').update(chartPercent, {
                    scaleColor: false,
                    barColor: chartBarColor,
                    trackColor: '#ccc'
                });

enkimatt added 2 commits May 28, 2015 13:22
added the ability to pass a new set of chart options in the update method, useful for changing colors while updating, ect..
@mezmi
Copy link
Author

mezmi commented May 28, 2015

@rendro Any ideas why this Travis CI build fails? Details are a bit sketchy...

PhantomJS is complaining saying this:
angular easypiechart directive should have percentage default value 0

I didn't mess with any of the default values, simply added another parameter to the update function and included 7ever's setOptions function.

Everything seems to function properly on my end.

@rendro
Copy link
Owner

rendro commented May 28, 2015

@enkimatt Don't worry about the Travis CI results. The rest cases are broken at the moment. I'll have a look at your PR soon. Thanks for your contribution.

@mezmi
Copy link
Author

mezmi commented May 28, 2015

My contribution is minimal, I should be thanking you - so, Thank you.. LOL. This chart is awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants