Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algebra: authenticated-poly: Implement shared polynomial floor division #27

Merged
merged 3 commits into from
Oct 18, 2023
Merged

algebra: authenticated-poly: Implement shared polynomial floor division #27

merged 3 commits into from
Oct 18, 2023

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Oct 18, 2023 •
edited
Loading

Purpose

This PR implements polynomial floor division between two polynomials that are shared. This is done in a constant round implementation given by Mohassel and Franklin.

To support this, a few other primitives are added:

  • Polynomial multiplicative inversion in the quotient ring $\mathbb{F}[x] / (x^n)$
  • Shared scalar multiplicative inversion

Testing

  • Unit and integration tests pass
  • Added unit tests for all new primitives

@joeykraut joeykraut force-pushed the joey/authenticated-inverse branch from 14e510b to 1704dbb Compare October 18, 2023 17:51
@joeykraut joeykraut requested a review from akirillo October 18, 2023 17:51
@joeykraut joeykraut marked this pull request as ready for review October 18, 2023 17:52
akirillo
akirillo approved these changes Oct 18, 2023
View reviewed changes
Copy link

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, mostly just annoying nits and pedantic requests for doc comment changes

src/algebra/poly/poly.rs Outdated Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Outdated Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Show resolved Hide resolved
src/algebra/poly/authenticated_poly.rs Outdated Show resolved Hide resolved
@joeykraut joeykraut force-pushed the joey/authenticated-inverse branch from 1704dbb to 0d55743 Compare October 18, 2023 23:11
@joeykraut joeykraut merged commit fd9c75a into master Oct 18, 2023
@joeykraut joeykraut deleted the joey/authenticated-inverse branch October 18, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirillo akirillo akirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykraut @akirillo