-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag search is not working #51
Comments
OK, I will need a bit more information to get a sense of what is going on on your end:
I just checked and see some troubles with the tag-search when ag is not installed. I should be able to fix it. I can help more when you:
and then send me the output of the console. If tag search isn't working, it is likely that the console shows a few error messages. |
Hi, there were indeed issues with the code for tag searches when not using ag. I hadn't touched it probably since I started using ag. If you update to the latest commit, tag search should work as expected. Please let me know if this fixed it for you. I assume you don't have ag installed. |
I am closing this for now, please re-open if your problem still exists |
I'm using Mac, and have ag installed. reloading plugin sublime_zk-master.sublime_zk During handling of the above exception, another exception occurred: Traceback (most recent call last):
|
Your setup looks a bit messed up. I can see you installed probably from a .ZIP. I would move the
There's another plugin, maybe called 1Self, that tries to make an HTTP request but seems to be misconfigured, hence the Sublime_ZK loads correctly and reports the path to
Since you're using I don't know where this comes from :
and then we have package control:
After that you can clearly see that you have some garbage in your user preferences:
So maybe start there first: remove the garbage from your User Preferences:
Comments in settings (JSON) files start with And maybe remove or configure that 1self plugin, maybe after all this, SublimeText and Sublime_ZK will work without problems. |
yntaxError: unexpected EOF while parsing Do you think sublime_zk can support non English language for tagging? Before I also had a problem with Korean titles which I therefore changed to English titles. I will delete Korean tags and see if problem continues. Thank you very much for your help - and also for this super wonderful program!!!! |
Awesome! Yeah, now we're getting close! This is definitely some utf8 encoding / decoding issue. We should get that to work. I will dig into this! Thanks for sharing that, now we have a Korean use case to test 😁 I might need your help testing... If ag complains, we can always use the bit slower python search... Send me a Korean tag if you like, I would love to test this on my Mac 😀 |
Definitely the problem is caused by Korean tags - I created a new project that has no Korean tags and the search works perfectly. I just copied some Korean tags for you to work with #행복 #안녕하세요 #서브라임 #사회 #사회란무엇인가 Thanks for your quick reply!! |
The thing I forgot mentioning is that Korean tags worked before - that's why I started using them. |
Cool that we're now down to the root cause. And thanks a lot for the tags to play with. I will check what can be done ... |
I recall having changed some of the tag code recently, I probably introduced the bug as a side-effect. We'll get it to work... 😀 |
Hi, I just pushed a fix! At least it works with the tags you provided. Apparently, according to python's unicode module, your tags contain unexpected bytes at the end, so I now ignore them. What's interesting: It works. Even searching for notes tagged by tags from the tag list (first Unicode is mysterious, sometimes. |
What do your sample tags mean, btw? I am curious 😄 |
Amazing! It works!!! Thank you so much. I am very happy I can use Korean tags now - it was a bit of troublesome to translate all these tags I used to the English ones. Don't know how to say thank you for your GREAT works. Thank you! Btw, these tags means #happiness #Hello #Sublime #Society #What is society :) |
You're welcome! Thank you for bringing this up! Now all non-English character-set users will benefit thanks to you! 👍 😄 I like your tags, especially the first one 😄 I changed the unicode handling everywhere, so, ideally it should work with Auto-TOC, too, and even Auto-Bib 😄 #행복 |
Oh, I just made these tags for you to try. My note tags are more serious ones than #hello :) By the way, I tried with note titles in Korean too - it seems it works as well. I should thank you for this too!! |
I did a manual install as automatic installation is not working. With the current version I downloaded, tag search #!, #? is not working - it worked before (when I first tried), but it stopped working now since I reinstalled sublime_zk
The text was updated successfully, but these errors were encountered: