Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor polish #7

Merged

Conversation

ilyaZar
Copy link
Contributor

@ilyaZar ilyaZar commented Sep 11, 2023

The warning popped up when I was copying the calc_sum() function from this demo package to a new R-package where I am using Rcpp and setting up the .vscode directory as usual.

Apparently, testthat deprecates testthat::context() in the 3rd edition which I am using in this package:

image

So I would simply remove it (it is not doing anything anyway) and also the annoying whitespaces.

- remove whitespaces in DESCRIPTION
- remove 'context()' as has been deprecated in testthat's 3rd ed
Copy link
Owner

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit ba141df into renkun-ken:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants