Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Changed the imagePullSecrets to spec. #72

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

svenvanhees
Copy link
Contributor

@svenvanhees svenvanhees commented Feb 26, 2021

Changed the imagePullSecrets to a spec rather than an attribute. The attribute was not placed in the correct yaml position.

For reference:

apiVersion: v1
kind: Pod
metadata:
  name: private-reg
spec:
  containers:
  - name: private-reg-container
    image: <your-private-image>
  imagePullSecrets:
  - name: regcred

https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/#create-a-pod-that-uses-your-secret

Fixes #71

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #72 (9e94608) into master (cc0c550) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage     95.00%   95.00%           
  Complexity      545      545           
=========================================
  Files            56       56           
  Lines          1300     1300           
=========================================
  Hits           1235     1235           
  Misses           65       65           
Impacted Files Coverage Δ Complexity Δ
src/Kinds/K8sIngress.php 100.00% <ø> (ø) 7.00 <0.00> (ø)
src/Kinds/K8sPod.php 95.83% <100.00%> (ø) 55.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0c550...9e94608. Read the comment docs.

@rennokki rennokki merged commit a8b3226 into renoki-co:master Feb 26, 2021
@rennokki
Copy link
Member

Thank you! 👍🏼

@rennokki rennokki changed the title Changed the imagePullSecrets to a spec. [2.x] Changed the imagePullSecrets to spec. Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a image pull secret does not work.
2 participants