Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong readme #56

Merged
merged 6 commits into from
Aug 27, 2020
Merged

fix: wrong readme #56

merged 6 commits into from
Aug 27, 2020

Conversation

viceice
Copy link
Member

@viceice viceice commented Aug 27, 2020 •
edited
Loading

  • fix readme
  • diable version lint (no version change would be a noop, so changes would be published by next bump)

ref #52 #54 #55

@viceice viceice marked this pull request as ready for review August 27, 2020 08:24
@viceice viceice requested a review from JamieMagee August 27, 2020 08:24
@viceice
Copy link
Member Author

viceice commented Aug 27, 2020

@JamieMagee Should the removed readme line be readded to the template instead?

@JamieMagee
Copy link
Contributor

No, it's not really relevant to the chart itself. It's more related to the helm-docs tool. I think this is correct.

@viceice
Copy link
Member Author

viceice commented Aug 27, 2020

So are you fine with this changes?

@JamieMagee
Copy link
Contributor

Yup. I'll merge 👍

@JamieMagee JamieMagee merged commit 3aceb1b into master Aug 27, 2020
@JamieMagee JamieMagee deleted the viceice-patch-1 branch August 27, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viceice @JamieMagee