matchCurrentVersion can't be used to disable minor updates only #21408

TWiStErRob · 2023-04-10T11:53:27Z

TWiStErRob
Apr 10, 2023

I'm using the Mend Renovate hosted app on github.com.

I'm using the Mend Renovate hosted app.

Was this something which used to work for you, and then stopped?

I never saw this working

Describe your problem.

Copied from https://github.com/renovatebot/renovate/issues/21407 (BTW, I cannot copy the markdown (because I can't edit my own issue), it is really annoying having to reformat the whole thing manually...) Anyway, I'm certain there is at least one bug here as I'm using and expecting everything as documented.

Can't make use of matchCurrentVersion in packageRules to enable/disable minor updates for new versions only.
To be more explicit:

major updates are turned off.
minor updates are turned off for < v7.0.
minor updates are turned on for ≥ v7.0.
patch updates are turned on by :separatePatchReleases.

Repro with specific details:
~~https://github.com/TWiStErRob/renovate-packageRules-disable-enable-ordering~~
I archived the above repo. Also it got forked here.

I tried two possible implementations of the above requirements, but both have problems.
Case 1 (in repo): matchCurrentVersion: <7.0 + enabled: false

[
  {
    "description": "Disable updating Gradle CI matrix, they use the latest patch of a specific minor.",
    "matchPackageNames": [ "gradle" ],
    "matchPaths": [ ".github/workflows/CI.yml" ],
    "matchCurrentVersion": "<7.0",
    "matchUpdateTypes": [ "minor" ],
    "enabled": false
  }
]

Case 2: enabled: false & matchCurrentVersion: >=7.0 + enabled: true

[
  {
    "description": "Disable updating Gradle CI matrix, they use the latest patch of a specific minor.",
    "matchPackageNames": [ "gradle" ],
    "matchPaths": [ ".github/workflows/CI.yml" ],
    "matchUpdateTypes": [ "minor" ],
    "enabled": false
  },
  {
     "description": "Enable latest versions.",
     "matchPackageNames": [ "gradle" ],
     "matchPaths": [ ".github/workflows/CI.yml" ],
     "matchCurrentVersion": ">=7.0",
     "matchUpdateTypes": [ "minor" ],
     "enabled": true
  }
]

See the repro for more details on what's wrong.

Relevant debug logs.

~~Couldn't find diagnostic info that would've helped me, please let me know which part would be necessary, otherwise repro is simple to get fresh logs.~~

Select me to see logs

DEBUG: packageFiles with updates
{
  "baseBranch": "master",
  "config": {
    "gradle-wrapper": [
      {
        "deps": [
          {
            "currentValue": "7.4.2",
            "currentVersion": "7.4.2",
            "datasource": "gradle-version",
            "depName": "gradle",
            "fixedVersion": "7.4.2",
            "homepage": "https://gradle.org",
            "isSingleVersion": true,
            "packageName": "gradle",
            "registryUrl": "https://services.gradle.org/versions/all",
            "replaceString": "https\\://services.gradle.org/distributions/gradle-7.4.2-bin.zip",
            "sourceUrl": "https://github.com/gradle/gradle",
            "versioning": "gradle",
            "warnings": [],
            "updates": [
              {
                "bucket": "minor",
                "newVersion": "7.6.1",
                "newValue": "7.6.1",
                "releaseTimestamp": "2023-02-24T13:54:42.000Z",
                "newMajor": 7,
                "newMinor": 6,
                "updateType": "minor",
                "branchName": "renovate/gradle-7.x"
              },
              {
                "bucket": "major",
                "newVersion": "8.0.2",
                "newValue": "8.0.2",
                "releaseTimestamp": "2023-03-03T16:41:37.000Z",
                "newMajor": 8,
                "newMinor": 0,
                "updateType": "major",
                "branchName": "renovate/gradle-8.x"
              }
            ]
          }
        ],
        "packageFile": "gradle/wrapper/gradle-wrapper.properties"
      }
    ],
    "regex": [
      {
        "datasourceTemplate": "gradle-version",
        "depNameTemplate": "gradle",
        "deps": [
          {
            "currentValue": "6.5",
            "currentVersion": "6.5",
            "datasource": "gradle-version",
            "depName": "gradle",
            "fixedVersion": "6.5",
            "homepage": "https://gradle.org",
            "isSingleVersion": true,
            "packageName": "gradle",
            "registryUrl": "https://services.gradle.org/versions/all",
            "replaceString": "  gradle: '6.5'",
            "sourceUrl": "https://github.com/gradle/gradle",
            "versioning": "gradle",
            "warnings": [],
            "updates": [
              {
                "bucket": "patch",
                "newVersion": "6.5.1",
                "newValue": "6.5.1",
                "releaseTimestamp": "2020-06-30T06:32:47.000Z",
                "newMajor": 6,
                "newMinor": 5,
                "updateType": "patch",
                "branchName": "renovate/gradle-6.5.x"
              },
              {
                "bucket": "minor",
                "newVersion": "6.9.4",
                "newValue": "6.9.4",
                "releaseTimestamp": "2023-02-22T08:43:12.000Z",
                "newMajor": 6,
                "newMinor": 9,
                "updateType": "minor",
                "branchName": "renovate/gradle-6.x"
              },
              {
                "bucket": "major",
                "newVersion": "8.0.2",
                "newValue": "8.0.2",
                "releaseTimestamp": "2023-03-03T16:41:37.000Z",
                "newMajor": 8,
                "newMinor": 0,
                "updateType": "major",
                "branchName": "renovate/gradle-8.x"
              }
            ]
          },
          {
            "currentValue": "6.6.1",
            "currentVersion": "6.6.1",
            "datasource": "gradle-version",
            "depName": "gradle",
            "fixedVersion": "6.6.1",
            "homepage": "https://gradle.org",
            "isSingleVersion": true,
            "packageName": "gradle",
            "registryUrl": "https://services.gradle.org/versions/all",
            "replaceString": "  gradle: '6.6.1'",
            "sourceUrl": "https://github.com/gradle/gradle",
            "versioning": "gradle",
            "warnings": [],
            "updates": [
              {
                "bucket": "minor",
                "newVersion": "6.9.4",
                "newValue": "6.9.4",
                "releaseTimestamp": "2023-02-22T08:43:12.000Z",
                "newMajor": 6,
                "newMinor": 9,
                "updateType": "minor",
                "branchName": "renovate/gradle-6.x"
              },
              {
                "bucket": "major",
                "newVersion": "8.0.2",
                "newValue": "8.0.2",
                "releaseTimestamp": "2023-03-03T16:41:37.000Z",
                "newMajor": 8,
                "newMinor": 0,
                "updateType": "major",
                "branchName": "renovate/gradle-8.x"
              }
            ]
          },
          {
            "currentValue": "6.8.2",
            "currentVersion": "6.8.2",
            "datasource": "gradle-version",
            "depName": "gradle",
            "fixedVersion": "6.8.2",
            "homepage": "https://gradle.org",
            "isSingleVersion": true,
            "packageName": "gradle",
            "registryUrl": "https://services.gradle.org/versions/all",
            "replaceString": "  gradle: '6.8.2'",
            "sourceUrl": "https://github.com/gradle/gradle",
            "versioning": "gradle",
            "warnings": [],
            "updates": [
              {
                "bucket": "patch",
                "newVersion": "6.8.3",
                "newValue": "6.8.3",
                "releaseTimestamp": "2021-02-22T16:13:28.000Z",
                "newMajor": 6,
                "newMinor": 8,
                "updateType": "patch",
                "branchName": "renovate/gradle-6.8.x"
              },
              {
                "bucket": "minor",
                "newVersion": "6.9.4",
                "newValue": "6.9.4",
                "releaseTimestamp": "2023-02-22T08:43:12.000Z",
                "newMajor": 6,
                "newMinor": 9,
                "updateType": "minor",
                "branchName": "renovate/gradle-6.x"
              },
              {
                "bucket": "major",
                "newVersion": "8.0.2",
                "newValue": "8.0.2",
                "releaseTimestamp": "2023-03-03T16:41:37.000Z",
                "newMajor": 8,
                "newMinor": 0,
                "updateType": "major",
                "branchName": "renovate/gradle-8.x"
              }
            ]
          },
          {
            "currentValue": "6.9.3",
            "currentVersion": "6.9.3",
            "datasource": "gradle-version",
            "depName": "gradle",
            "fixedVersion": "6.9.3",
            "homepage": "https://gradle.org",
            "isSingleVersion": true,
            "packageName": "gradle",
            "registryUrl": "https://services.gradle.org/versions/all",
            "replaceString": "  gradle: '6.9.3'",
            "sourceUrl": "https://github.com/gradle/gradle",
            "versioning": "gradle",
            "warnings": [],
            "updates": [
              {
                "bucket": "patch",
                "newVersion": "6.9.4",
                "newValue": "6.9.4",
                "releaseTimestamp": "2023-02-22T08:43:12.000Z",
                "newMajor": 6,
                "newMinor": 9,
                "updateType": "patch",
                "branchName": "renovate/gradle-6.9.x"
              },
              {
                "bucket": "major",
                "newVersion": "8.0.2",
                "newValue": "8.0.2",
                "releaseTimestamp": "2023-03-03T16:41:37.000Z",
                "newMajor": 8,
                "newMinor": 0,
                "updateType": "major",
                "branchName": "renovate/gradle-8.x"
              }
            ]
          },
          {
            "currentValue": "7.4.2",
            "currentVersion": "7.4.2",
            "datasource": "gradle-version",
            "depName": "gradle",
            "fixedVersion": "7.4.2",
            "homepage": "https://gradle.org",
            "isSingleVersion": true,
            "packageName": "gradle",
            "registryUrl": "https://services.gradle.org/versions/all",
            "replaceString": "  gradle: '7.4.2'",
            "sourceUrl": "https://github.com/gradle/gradle",
            "versioning": "gradle",
            "warnings": [],
            "updates": [
              {
                "bucket": "minor",
                "newVersion": "7.6.1",
                "newValue": "7.6.1",
                "releaseTimestamp": "2023-02-24T13:54:42.000Z",
                "newMajor": 7,
                "newMinor": 6,
                "updateType": "minor",
                "branchName": "renovate/gradle-7.x"
              },
              {
                "bucket": "major",
                "newVersion": "8.0.2",
                "newValue": "8.0.2",
                "releaseTimestamp": "2023-03-03T16:41:37.000Z",
                "newMajor": 8,
                "newMinor": 0,
                "updateType": "major",
                "branchName": "renovate/gradle-8.x"
              }
            ]
          }
        ],
        "matchStrings": [
          "  gradle: '(?<currentValue>.*)'"
        ],
        "packageFile": ".github/workflows/CI.yml",
        "versioningTemplate": "gradle"
      },
      {
        "datasourceTemplate": "gradle-version",
        "depNameTemplate": "gradle",
        "deps": [
          {
            "currentValue": "7.4.2",
            "currentVersion": "7.4.2",
            "datasource": "gradle-version",
            "depName": "gradle",
            "fixedVersion": "7.4.2",
            "homepage": "https://gradle.org",
            "isSingleVersion": true,
            "packageName": "gradle",
            "registryUrl": "https://services.gradle.org/versions/all",
            "replaceString": "test.gradle.version=7.4.2",
            "sourceUrl": "https://github.com/gradle/gradle",
            "versioning": "gradle",
            "warnings": [],
            "updates": [
              {
                "bucket": "minor",
                "newVersion": "7.6.1",
                "newValue": "7.6.1",
                "releaseTimestamp": "2023-02-24T13:54:42.000Z",
                "newMajor": 7,
                "newMinor": 6,
                "updateType": "minor",
                "branchName": "renovate/gradle-7.x"
              },
              {
                "bucket": "major",
                "newVersion": "8.0.2",
                "newValue": "8.0.2",
                "releaseTimestamp": "2023-03-03T16:41:37.000Z",
                "newMajor": 8,
                "newMinor": 0,
                "updateType": "major",
                "branchName": "renovate/gradle-8.x"
              }
            ]
          }
        ],
        "matchStrings": [
          "test.gradle.version=(?<currentValue>.*)"
        ],
        "packageFile": "gradle.properties",
        "versioningTemplate": "gradle"
      }
    ]
  }
}

Answered by rarkins

Apr 12, 2023

You are using gradle versioning for these dependencies, but I don't think <7.0 is valid Gradle syntax. I modified your reproduction config renovate-reproductions/21408@d25ac7b and found one of the five PRs was autoclosed: renovate-reproductions/21408#5

View full answer

rarkins · 2023-04-11T04:37:59Z

rarkins
Apr 11, 2023
Maintainer

Please include the packageFiles with updates log message for this dependency

6 replies

TWiStErRob Apr 11, 2023
Author

Added, this is the same (with a bit more detail) as the bottom of Dependency Dashboard in the repro.

The dependencies are all found, it's the filtering based on rules that seem to be not working.

rarkins Apr 11, 2023
Maintainer

There's now too much irrelevant info in the logs. Pick one dependency and one config to focus on. Reduce the logs to only that dependency and clearly state which config it was generated from

TWiStErRob Apr 11, 2023
Author

Please have a look at the README in the repro. It IS a complex issue:
https://github.com/TWiStErRob/renovate-packageRules-disable-enable-ordering

(I spent 2 days trying to figure this one out why it's not working as intended and minimizing a repro, please have a read.)

The logs were generated from is the one in the repo:
https://github.com/TWiStErRob/renovate-packageRules-disable-enable-ordering/blob/master/renovate.json
(it's the most recent execution)

rarkins Apr 12, 2023
Maintainer

You are using gradle versioning for these dependencies, but I don't think <7.0 is valid Gradle syntax. I modified your reproduction config renovate-reproductions/21408@d25ac7b and found one of the five PRs was autoclosed: renovate-reproductions/21408#5

Answer selected by TWiStErRob

rarkins Apr 12, 2023
Maintainer

Ref: https://docs.gradle.org/current/userguide/single_versions.html

TWiStErRob Apr 13, 2023
Author

That's crazy! I had multiple variants using that syntax during the development of the repro 🤦‍♂️. Thanks for the highlight.

Here's your response encoded in the documentation ;) → #21485

2023-04-11T04:38:15Z

github-actions[bot]
bot Apr 11, 2023

Hi there,

We found a problem with the logs. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Renovate app (GitHub):

Go to the affected PR, and search for "View repository job log here"
Select the link to go to the "Mend Renovate Dashboard" and log in
You are now in the correct repository log overview screen
Copy/paste the correct log
Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

If you're running self-hosted, run with LOG_LEVEL=debug in your environment variables and search for whatever dependency/branch/PR that is causing the problem.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

Good luck,

The Renovate team

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

matchCurrentVersion can't be used to disable minor updates only #21408

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 2 comments 6 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

matchCurrentVersion can't be used to disable minor updates only #21408

TWiStErRob Apr 10, 2023

I'm using the Mend Renovate hosted app on github.com.

Was this something which used to work for you, and then stopped?

Describe your problem.

Relevant debug logs.

Replies: 2 comments · 6 replies

rarkins Apr 11, 2023 Maintainer

TWiStErRob Apr 11, 2023 Author

rarkins Apr 11, 2023 Maintainer

TWiStErRob Apr 11, 2023 Author

rarkins Apr 12, 2023 Maintainer

rarkins Apr 12, 2023 Maintainer

TWiStErRob Apr 13, 2023 Author

github-actions[bot] bot Apr 11, 2023

No logs at all

Finding logs on hosted app

Finding logs when self-hosting

Insufficient logs

Formatting your logs

TWiStErRob
Apr 10, 2023

Replies: 2 comments 6 replies

rarkins
Apr 11, 2023
Maintainer

TWiStErRob Apr 11, 2023
Author

rarkins Apr 11, 2023
Maintainer

TWiStErRob Apr 11, 2023
Author

rarkins Apr 12, 2023
Maintainer

rarkins Apr 12, 2023
Maintainer

TWiStErRob Apr 13, 2023
Author

github-actions[bot]
bot Apr 11, 2023